linux-kernel - Re: [PATCH] irq: handle irq0 special only on x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091209093518.GC23236@pengutronix.de>
Date:	Wed, 9 Dec 2009 10:35:18 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH] irq: handle irq0 special only on x86

Hello,

On Wed, Dec 09, 2009 at 05:28:09PM +0800, Américo Wang wrote:
> 2009/12/9 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>:
> > I just noticed this when digging in the irq handling.  At least for arm
> > this doesn't make sense.  Not sure if x86 is the only arch this test
> > is valid for, but probably it is.
> 
> No, it is not.
> 
> Try grep -Inr 'irq0' arch/*/kernel.
Some hits are unrelated, some others are usage of an irq0.  AFAIK irq0
is reported on x86 for misrouted irqs[1].  I think on other archs it's just
an ordinary irq.  If you still think I missed something in the output of
your grep, please be a bit more specific.

Thanks
Uwe

[1] I don't really know x86, so this might be complete non-sense.

> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > Cc: Thomas Gleixner <tglx@...utronix.de>
> > Cc: Ingo Molnar <mingo@...hat.com>
> > Cc: H. Peter Anvin <hpa@...or.com>
> > ---
> >  kernel/irq/spurious.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/kernel/irq/spurious.c b/kernel/irq/spurious.c
> > index 22b0a6e..4996b66 100644
> > --- a/kernel/irq/spurious.c
> > +++ b/kernel/irq/spurious.c
> > @@ -199,8 +199,10 @@ try_misrouted_irq(unsigned int irq, struct irq_desc *desc,
> >        if (irqfixup < 2)
> >                return 0;
> >
> > +#if defined(CONFIG_ARCH_X86)
> >        if (!irq)
> >                return 1;
> > +#endif
> >
> >        /*
> >         * Since we don't get the descriptor lock, "action" can
> 

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/