[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4B211346.2000205@gmail.com>
Date: Thu, 10 Dec 2009 16:27:02 +0100
From: Jes Sorensen <jes.sorensen@...il.com>
To: Alan Jenkins <sourcejedi.lkml@...glemail.com>
CC: linux-acpi@...r.kernel.org,
linux-kernel <linux-kernel@...r.kernel.org>, lenb@...nel.org,
Matthew Garrett <mjg59@...f.ucam.org>
Subject: PATCH: Toshiba Bluetooth enabler (v3)
On 12/09/2009 02:17 PM, Alan Jenkins wrote:
>> Fixed, this version only calls the enabler if the switch is at ON at
>> resume time.
>
> Ah... I think add() has the same problem as well though? I.e. the
> driver will not work if the switch is disabled at load time.
>
> I would change it in enable() (and then try to think of a new name for
> it, maybe try_enable()).
Sorta did that, it should do the right thing in all those cases now.
Otherwise I am pretty pleased with it now. Unless there's strong
objections, I'd say it's good to go.
Cheers,
Jes
View attachment "0002-toshiba-bluetooth-v3.patch" of type "text/plain" (6156 bytes)
Powered by blists - more mailing lists