linux-kernel - Re: [tip:perf/urgent] x86, perf events: Check if we have APIC enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 10 Dec 2009 21:15:58 +0300
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	mingo@...hat.com, hpa@...or.com, paulus@...ba.org, acme@...hat.com,
	linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
	efault@....de, fweisbec@...il.com, Ralf.Hildebrandt@...rite.de,
	tglx@...utronix.de, mingo@...e.hu
Cc:	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/urgent] x86, perf events: Check if we have APIC
	enabled

On Thu, Dec 10, 2009 at 05:18:32PM +0000, tip-bot for Cyrill Gorcunov wrote:
> Commit-ID:  125580380f418000b1a06d9a54700f1191b6e561
> Gitweb:     http://git.kernel.org/tip/125580380f418000b1a06d9a54700f1191b6e561
> Author:     Cyrill Gorcunov <gorcunov@...nvz.org>
> AuthorDate: Thu, 10 Dec 2009 19:56:34 +0300
> Committer:  Ingo Molnar <mingo@...e.hu>
> CommitDate: Thu, 10 Dec 2009 18:00:30 +0100
> 
> x86, perf events: Check if we have APIC enabled
> 
> Ralf Hildebrandt reported this boot warning:
> 
> | Running a vanilla 2.6.32 as Xen DomU, I'm getting:
> |
> | [    0.000999] CPU: Physical Processor ID: 0
> | [    0.000999] CPU: Processor Core ID: 1
> | [    0.000999] Performance Events: AMD PMU driver.
> | [    0.000999] ------------[ cut here ]------------
> | [    0.000999] WARNING: at arch/x86/kernel/apic/apic.c:249 native_apic_write_dummy
> 
> So we need to check if APIC functionality is available, and
> not just in the P6 driver but elsewhere as well.
> 
> Reported-by: Ralf Hildebrandt <Ralf.Hildebrandt@...rite.de>
> Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Mike Galbraith <efault@....de>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Arnaldo Carvalho de Melo <acme@...hat.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> LKML-Reference: <20091210165634.GF5086@...ovo>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
> ---
>  arch/x86/kernel/cpu/perf_event.c |   18 ++++++++++++------
>  1 files changed, 12 insertions(+), 6 deletions(-)
>
...

Btw, is there some particular reason to have x86_pmu::apic item?
Can't we use cpu_has_apic directly? Or there some plans about
this item? Or I miss something obvious?
 
	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/