linux-kernel - Re: [PATCH -next] net: niu uses crc32, so select CRC32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091210135932.b0774727.randy.dunlap@oracle.com>
Date:	Thu, 10 Dec 2009 13:59:32 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	David Miller <davem@...emloft.net>
Cc:	sfr@...b.auug.org.au, netdev@...r.kernel.org,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] net: niu uses crc32, so select CRC32

On Thu, 10 Dec 2009 13:51:38 -0800 (PST) David Miller wrote:

> From: Randy Dunlap <randy.dunlap@...cle.com>
> Date: Thu, 10 Dec 2009 09:31:03 -0800
> 
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> > 
> > niu drivers uses crc32 functions, so it needs to select CRC32.
> > 
> > niu.c:(.text+0x18a7f8): undefined reference to `crc32_le'
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Applied, thanks Randy.
> 
> That dependency is quite indirect, it's due to ether_crc_*().
> I bet a quick grep for that will find several other drivers
> missing this Kconfig bit.

Yes, I've noticed that also...

---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/