linux-kernel - Re: [PATCH 04/10] tracing: __dynamic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1260490803.2146.311.camel@gandalf.stny.rr.com>
Date:	Thu, 10 Dec 2009 19:20:03 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Jason Baron <jbaron@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 04/10] tracing: __dynamic_array() also defines fields

On Wed, 2009-12-09 at 15:15 +0800, Lai Jiangshan wrote:
> dynamic array is also added to struct ftrace_event_call->fields.

Could you add to the change log which events use it. I see bprint and
print. But this change log is still lacking. It should explain what
features this fixes.

But as for the patch itself:

Acked-by: Steven Rostedt <rostedt@...dmis.org>

Thanks,

-- Steve



> 
> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>
> ---
> diff --git a/kernel/trace/trace_export.c b/kernel/trace/trace_export.c
> index 458e5bf..511bc36 100644
> --- a/kernel/trace/trace_export.c
> +++ b/kernel/trace/trace_export.c
> @@ -174,7 +174,12 @@ ftrace_format_##name(struct ftrace_event_call *unused,			\
>  		return ret;
>  
>  #undef __dynamic_array
> -#define __dynamic_array(type, item)
> +#define __dynamic_array(type, item)					\
> +	ret = trace_define_field(event_call, #type, #item,		\
> +				 offsetof(typeof(field), item),		\
> +				 0, is_signed_type(type), FILTER_OTHER);\
> +	if (ret)							\
> +		return ret;
>  
>  #undef FTRACE_ENTRY
>  #define FTRACE_ENTRY(name, struct_name, id, tstruct, print)		\
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/