linux-kernel - Re: [PATCH] Fix compilation error of drivers/staging/panel/panel.c w/ custom lcd charset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091215211953.GE11857@1wt.eu>
Date:	Tue, 15 Dec 2009 22:19:53 +0100
From:	Willy Tarreau <w@....eu>
To:	Peter Huewe <peterhuewe@....de>
Cc:	Greg Kroah-Hartman <greg@...ah.com>, devel@...verdev.osuosl.org,
	Sudhakar Rajashekhara <sudhakar.raj@...com>,
	Costantino Leandro <lcostantino@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix compilation error of drivers/staging/panel/panel.c w/ custom lcd charset

On Tue, Dec 15, 2009 at 06:21:45AM +0100, Peter Huewe wrote:
> When compiling panel.c with a DEFAULT_LCD_CHARSET it fails to compile
> with the following error message:
> drivers/staging/panel/panel.c: In function >>lcd_init<<:
> drivers/staging/panel/panel.c:1396: error: expected expression before
> >>;<< token
> drivers/staging/panel/panel.c:1475: error: expected expression before
> >>;<< token
> make[3]: *** [drivers/staging/panel/panel.o] error 1
> make[2]: *** [drivers/staging/panel] error 2
> make[1]: *** [drivers/staging] error 2

(...)
>  #ifdef CONFIG_PANEL_LCD_CHARSET
>  #undef DEFAULT_LCD_CHARSET
> -#define DEFAULT_LCD_CHARSET
> +#define DEFAULT_LCD_CHARSET CONFIG_PANEL_LCD_CHARSET
>  #endif

Wow! I don't understand how this managed to slip through the various
tests for that long. That code is the the same in my 2.4 driver too,
so that means it has never worked for the last 5 years !

Obvious ACK from me, but please take a quick look at the place
where this define is used to ensure that any expected setting of
CONFIG_PANEL_LCD_CHARSET will not result in some other cryptic
error messages being sent to the user.

Thanks!
Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/