linux-kernel - Re: [mm][RFC][PATCH 0/11] mm accessor updates.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091216113158.GE15031@basil.fritz.box>
Date:	Wed, 16 Dec 2009 12:31:58 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>, cl@...ux-foundation.org,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"mingo@...e.hu" <mingo@...e.hu>, minchan.kim@...il.com
Subject: Re: [mm][RFC][PATCH 0/11] mm accessor updates.

On Wed, Dec 16, 2009 at 08:12:18PM +0900, KAMEZAWA Hiroyuki wrote:
> On Wed, 16 Dec 2009 11:49:51 +0100
> Andi Kleen <andi@...stfloor.org> wrote:
> 
> > On Wed, Dec 16, 2009 at 07:31:09PM +0900, KAMEZAWA Hiroyuki wrote:
> > > On Wed, 16 Dec 2009 11:28:06 +0100
> > > Andi Kleen <andi@...stfloor.org> wrote:
> > > 
> > > > > > Also the patches didn't fare too well in testing unfortunately.
> > > > > > 
> > > > > > I suspect we'll rather need multiple locks split per address
> > > > > > space range.
> > > > > 
> > > > > This set doesn't include any changes of the logic. Just replace all mmap_sem.
> > > > > I think this is good start point (for introducing another logic etc..)
> > > > 
> > > > The problem is that for range locking simple wrapping the locks
> > > > in macros is not enough. You need more changes.
> > > > 
> > > maybe. but removing scatterred mmap_sem from codes is the first thing to do.
> > > I think this removing itself will take 3 month or a half year.
> > > (So, I didn't remove mmap_sem and leave it as it is.)
> > 
> > I suspect you would just need to change them again then.
> > 
> Do you have alternative recommendation rather than wrapping all accesses by
> special functions ?

Work out what changes need to be done for ranged mmap locks and do them all
in one pass.

Unfortunately I don't know yet either how exactly these changes look 
like, figuring that out is the hard work part in it.

I suspect it would need changing of the common vma list walk loop
pattern.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/