linux-kernel - Re: [PATCH] move eject code from zd1211rw to usb-storage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B28C798.502@draisberghof.de>
Date:	Wed, 16 Dec 2009 12:42:16 +0100
From:	Josua Dietze <digidietze@...isberghof.de>
To:	Oliver Neukum <oliver@...kum.org>
CC:	Matthew Dharm <mdharm-kernel@...-eyed-alien.net>,
	Stefan Seyfried <stefan.seyfried@...glemail.com>,
	linux-usb@...r.kernel.org, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net,
	Stefan Seyfried <seife@...airon.com>
Subject: Re: [PATCH] move eject code from zd1211rw to usb-storage

Oliver Neukum schrieb:

> Am Dienstag, 15. Dezember 2009 19:03:00 schrieb Matthew Dharm:
>>> This would break existing systems and thus introduce a regression.
>>> We'd need to go through a feature removal process. For the time being
>>> I see no alternative to Seife's patch, as we cannot introduce ejection
>>> code to another wireless driver and need to support these devices.
>> The right answer here is neither to move the eject code nor to introduce
>> more of it.  New devices should be supported via userspace.
> 
> Usually I would agree, but in this case the vendor reused IDs.
> The legacy kernel space switcher and user space would race.

User space can test for device/interface class (which will 
supposedly change even if the IDs do not) and base it's actions on 
that. It was done before.

Apart from that issue, I can see that there is a problem with a 
device that has worked without "external" handling up to now. 
Unfortunately, I can't think about a clean solution.

Josua
-- 
Man is the only creature on earth enabled to take a
warm meal while flying!                      Loriot
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/