linux-kernel - Re: [PATCH] ep93xx_eth.c: general cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1260984721.30093.23.camel@Joe-Laptop.home>
Date:	Wed, 16 Dec 2009 09:32:01 -0800
From:	Joe Perches <joe@...ches.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	kernel list <linux-kernel@...r.kernel.org>,
	"Nick M." <nickm@...ionengravers.com>,
	Lennert Buytenhek <kernel@...tstofly.org>,
	David Miller <davem@...emloft.net>
Subject: Re: [PATCH] ep93xx_eth.c: general cleanup

On Wed, 2009-12-16 at 12:09 -0500, H Hartley Sweeten wrote:
> +#define pr_fmt(fmt) KBUILD_MODNAME ": %s: " fmt, __func__

I think KBUILD_MODNAME ":%s: " fmt, __func__
or its equivalent direct use is more common.
It's possibly useful to standardize.

> -#define DRV_MODULE_NAME		"ep93xx-eth"
> -#define DRV_MODULE_VERSION	"0.1"
> +#include <mach/hardware.h>

I think these sorts of defines are common and useful.

>  static int __init ep93xx_eth_init_module(void)
>  {
> -	printk(KERN_INFO DRV_MODULE_NAME " version " DRV_MODULE_VERSION " loading\n");

Why remove this printk completely?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/