[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <200912172215402654375@gmail.com>
Date: Thu, 17 Dec 2009 22:15:43 +0800
From: "Liuweni" <qingshenlwy@...il.com>
To: "linux-fsdevel" <linux-fsdevel@...r.kernel.org>,
"linux-kernel" <linux-kernel@...r.kernel.org>,
"viro" <viro@...iv.linux.org.uk>
Cc: "Xiao Guangrong" <xiaoguangrong@...fujitsu.com>,
"strongzgy" <strongzgy@...il.com>, "Liu Hui" <onlyflyer@...il.com>,
"qingshenlwy" <qingshenlwy@...il.com>
Subject: [PATCH 1/3]posix acl:Add an acl check
In this function, the parameter of acl will be called by FOREACH_ACL_ENTRY(macro)
without null point check. I add a null point check to it.
---
Signed-off-by: Liuwenyi <qingshenlwy@...il.com>
Cc: Alexander Viro <viro@...iv.linux.org.uk>
Cc: linux-fsdevel@...r.kernel.org
Cc: linux-kernel@...r.kernel.org
---
diff --git a/fs/posix_acl.c b/fs/posix_acl.c
index 39df95a..956df14 100644
--- a/fs/posix_acl.c
+++ b/fs/posix_acl.c
@@ -76,6 +76,9 @@ posix_acl_valid(const struct posix_acl *acl)
unsigned int id = 0; /* keep gcc happy */
int needs_mask = 0;
+ if (!acl)
+ return -EINVAL;
+
FOREACH_ACL_ENTRY(pa, acl, pe) {
if (pa->e_perm & ~(ACL_READ|ACL_WRITE|ACL_EXECUTE))
return -EINVAL;
--------------
Best Regards,
Liuweni
2009-12-17
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists