linux-kernel - Re: [PATCH 1/3]posix acl:Add an acl check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20091217141908.GV7812@parisc-linux.org>
Date:	Thu, 17 Dec 2009 07:19:08 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	Liuweni <qingshenlwy@...il.com>
Cc:	linux-fsdevel <linux-fsdevel@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	viro <viro@...iv.linux.org.uk>,
	Xiao Guangrong <xiaoguangrong@...fujitsu.com>,
	strongzgy <strongzgy@...il.com>, Liu Hui <onlyflyer@...il.com>
Subject: Re: [PATCH 1/3]posix acl:Add an acl check

On Thu, Dec 17, 2009 at 10:15:43PM +0800, Liuweni wrote:
> In this function, the parameter of acl will be called by FOREACH_ACL_ENTRY(macro) 
> without null point check. I add a null point check to it. 

All the callers of posix_acl_valid() currently check for acl being a
null pointer themselves.  Moving the check to posix_acl_valid() certainly
seems like a good idea to me, but you need to delete the check from all
the callers.

Further, it seems like many of the callers might have a PTR_ERR value
for 'acl', so you should also move this check into posix_acl_valid().

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/