[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <97949e3e0912171315g537903f7m9461ea8399dc018c@mail.gmail.com>
Date: Thu, 17 Dec 2009 13:15:04 -0800
From: Laurent Chavey <chavey@...gle.com>
To: "Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Cc: Roger Oksanen <roger.oksanen@...helsinki.fi>,
Alan Stern <stern@...land.harvard.edu>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
"Allan, Bruce W" <bruce.w.allan@...el.com>,
"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@...el.com>,
"Ronciak, John" <john.ronciak@...el.com>,
"e1000-devel@...ts.sourceforge.net"
<e1000-devel@...ts.sourceforge.net>,
Kernel development list <linux-kernel@...r.kernel.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
David Miller <davem@...emloft.net>
Subject: Re: e100 REGRESSION in 2.6.32 (PATCH v2)
when using DMAPOOL_DEBUG, do we really want to
over-write memset(retval, POOL_POISON_ALLOCATED, pool->size);
set in dma_pool_alloc.
On Thu, Dec 17, 2009 at 9:21 AM, Brandeburg, Jesse
<jesse.brandeburg@...el.com> wrote:
>
> On Thu, 17 Dec 2009, Roger Oksanen wrote:
>> e100: Fix broken cbs accounting due to missing memset.
>>
>> Alan Stern noticed that e100 caused slab corruption.
>> commit 98468efddb101f8a29af974101c17ba513b07be1 changed
>> the allocation of cbs to use dma pools that don't return zeroed memory,
>> especially the cb->status field used to track which cb to clean, causing
>> (the visible) double freeing of skbs and a wrong free cbs count.
>>
>> Now the cbs are explicitly zeroed at allocation time.
>>
>> Reported-by: Alan Stern <stern@...land.harvard.edu>
>> Tested-by: Alan Stern <stern@...land.harvard.edu>
>> Signed-off-by: Roger Oksanen <roger.oksanen@...helsinki.fi>
>
> Change looks reasonable, ACK.
>
> should we also consider a followon patch to zero memory allocated with
> pci_pools? Seems useful.
>
> Acked-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists