linux-kernel - Re: e100 REGRESSION in 2.6.32 (PATCH v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091218.201914.102544489.davem@davemloft.net>
Date:	Fri, 18 Dec 2009 20:19:14 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jesse.brandeburg@...el.com
Cc:	roger.oksanen@...helsinki.fi, stern@...land.harvard.edu,
	jeffrey.t.kirsher@...el.com, bruce.w.allan@...el.com,
	peter.p.waskiewicz.jr@...el.com, john.ronciak@...el.com,
	e1000-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: e100 REGRESSION in 2.6.32 (PATCH v2)

From: "Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Date: Thu, 17 Dec 2009 09:21:49 -0800 (Pacific Standard Time)

> 
> On Thu, 17 Dec 2009, Roger Oksanen wrote:
>> e100: Fix broken cbs accounting due to missing memset.
>> 
>> Alan Stern noticed that e100 caused slab corruption.
>> commit 98468efddb101f8a29af974101c17ba513b07be1 changed
>> the allocation of cbs to use dma pools that don't return zeroed memory,
>> especially the cb->status field used to track which cb to clean, causing
>> (the visible) double freeing of skbs and a wrong free cbs count.
>> 
>> Now the cbs are explicitly zeroed at allocation time.
>> 
>> Reported-by: Alan Stern <stern@...land.harvard.edu>
>> Tested-by: Alan Stern <stern@...land.harvard.edu>
>> Signed-off-by: Roger Oksanen <roger.oksanen@...helsinki.fi>
> 
> Change looks reasonable, ACK.

Applied, thanks everyone.  I'll try to requeue the e100 stuff
together into -stable again now that this is resolved.

> should we also consider a followon patch to zero memory allocated with 
> pci_pools?  Seems useful.

Nah, it's more fun debugging subtle bugs like this one.
:-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/