linux-kernel - Re: [PATCH] [1/2] SYSCTL: Make bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1d429o1g5.fsf@fess.ebiederm.org>
Date:	Sun, 20 Dec 2009 12:06:02 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [1/2] SYSCTL: Make bin_table not const

Andi Kleen <andi@...stfloor.org> writes:

> On Sat, Dec 19, 2009 at 09:40:56AM -0800, Linus Torvalds wrote:
>> 
>> 
>> On Sat, 19 Dec 2009, Andi Kleen wrote:
>> > 
>> > Turn all the bin_tables from const to non-const. This is needed for the next
>> > patch. Unfortunately there were a lot of them, so the patch is rather 
>> > large, but it is completely mechanic. 
>> 
>> Ouch. I hate this.
>> 
>> I'd much rather have a constant sysctl bin_table.
>
> Understood. I'll poke at that and try to come up with a tested patch
> tomorrow or so.

Is printk_ratelimit truly ineffective at what it does?

Arguably we don't need to warn anywhere near that often, so even
if printk_ratelimit works we are good.

If printk_ratelimit let's too much through we really should also write
a patch to let fewer messages through that way.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/