linux-kernel - Re: [PATCH] [1/2] SYSCTL: Make bin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091220210650.GA5143@basil.fritz.box>
Date:	Sun, 20 Dec 2009 22:06:50 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] [1/2] SYSCTL: Make bin_table not const

> Is printk_ratelimit truly ineffective at what it does?
> 
> Arguably we don't need to warn anywhere near that often, so even
> if printk_ratelimit works we are good.
> 
> If printk_ratelimit let's too much through we really should also write
> a patch to let fewer messages through that way.

Any time based rate is too much for compatibility. Assume even if you only 
printed one per hour and the user keeps running a program that 
uses sysctl it would still be >5000 messages each month.

-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/