linux-kernel - Re: [PATCH] perf tools: Prevent from BITS_PER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B2DB1F8.2070006@goop.org>
Date:	Sat, 19 Dec 2009 21:11:20 -0800
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
CC:	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Paul Mackerras <paulus@...ba.org>
Subject: Re: [PATCH] perf tools: Prevent from BITS_PER_LONG redefinition

On 12/19/2009 06:34 AM, Frederic Weisbecker wrote:
> Yeah but we need it from the CPP level.
> We include such code located in kernel headers:
>
> static __always_inline unsigned long __fls(unsigned long word)
> {
> 	int num = BITS_PER_LONG - 1;
>
> #if BITS_PER_LONG == 64
> 	if (!(word&  (~0ul<<  32))) {
> 		num -= 32;
> 		word<<= 32;
> 	}
> #endif
> 	if (!(word&  (~0ul<<  (BITS_PER_LONG-16)))) {
> 		num -= 16;
> 		word<<= 16;
> 	}
>
>
> And sizeof() is not defined :)
>    

You can use if() with a constant expression instead of #if.

     J
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/