linux-kernel - Re: BKL use in ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091221170237.GA5384@redhat.com>
Date:	Mon, 21 Dec 2009 18:02:37 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
	Roland McGrath <roland@...hat.com>
Subject: Re: BKL use in ptrace

(add Roland)

On 12/20, Andi Kleen wrote:
>
> ptrace has this comment/BKL use:
>
>         /*
>          * This lock_kernel fixes a subtle race with suid exec
>          */
>         lock_kernel();
>
> But unless I'm blind I don't see execve actually getting the BKL
> anywhere. So is this comment outdated or misleading (is the race with exit?)
> or is there a bug?

I never understood this lock_kernel().

In any case it looks outdated. We were going to kill it "soon",
along with other ptrace changes.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/