linux-kernel - Re: [PATCH] prctl: return MCE process flags through pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091223095223.GB20539@basil.fritz.box>
Date:	Wed, 23 Dec 2009 10:52:23 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Andi Kleen <andi@...stfloor.org>,
	"Smith, GeoffX" <geoffx.smith@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Michael Stone <michael@...top.org>
Subject: Re: [PATCH] prctl: return MCE process flags through pointer

On Tue, Dec 22, 2009 at 05:34:24PM -0800, Andrew Morton wrote:
> On Wed, 23 Dec 2009 02:14:51 +0100 Andi Kleen <andi@...stfloor.org> wrote:
> 
> > "Smith, GeoffX" <geoffx.smith@...el.com> writes:
> > 
> > > This patch fixes the semantics of prctl() option PR_MCE_KILL_GET 
> > > to pass the return value through *arg2.
> > >
> > > With this change, the option now follows the same conventions as the
> > > other "get" options added since 2.6.0, and also brings it into
> > > conformance with the advice in chapter 16 of Documentation/CodingStyle.
> > >
> > > This prctl() option was only added within the last month, so there are
> > > not any production applications to break.  This patch applies cleanly
> > > to mainline and to 2.6.32.2 for backporting.
> > 
> > It breaks the test suite, the man pages, qemu and one slide deck at least.
> > 
> 
> Should've got it right the first time.

To be honest it's not fully clear to me what is "wrong" with returning
the return value with "return".

If there was a security bug or something maybe such a radical step
as changing a published API would be justified, but for this I'm sceptical.

> 
> What goes wrong with qemu?

It's the main current user of this interface currently.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/