linux-kernel - Re: mac80211 suspend corner case (was: Asus eeepc 1008HA suspend issue and mac80211 suspend corner) case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1261586828.7304.13.camel@johannes.local>
Date:	Wed, 23 Dec 2009 17:47:08 +0100
From:	Johannes Berg <johannes@...solutions.net>
To:	"Luis R. Rodriguez" <lrodriguez@...eros.com>
Cc:	Luis Rodriguez <Luis.Rodriguez@...eros.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	Alan Jenkins <alan-jenkins@...fmail.co.uk>
Subject: Re: mac80211 suspend corner case (was: Asus eeepc 1008HA suspend
 issue and mac80211 suspend corner) case

On Wed, 2009-12-23 at 08:28 -0800, Luis R. Rodriguez wrote:

> > Well it seems to me that if the driver determines that the hardware
> is
> > unreachable or not responding, it would unregister it from mac80211,
> > which would clean up all user-visible state, obviously.
> 
> The drivers would not know this until it fails on the first call
> from mac80211 which would be start().

Which is why this patch may be a good way to solve that particular
problem.

> > The patch above seems ok to me, but basically papers over the
> problem.
> > If the start there fails, the driver will have to unregister the hw
> > since any subsequent start will fail as well.
> 
> How about just having mac80211 do that for drivers where the start()
> fails and we are resuming? I can give that a shot.

No way, the driver will invariably assume things are still going and
might later unregister etc. Too much magic.

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)