linux-kernel - Re: [PATCH 07/37] kgdb,sparc: Add in kgdb_arch_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091223.134837.189694575.davem@davemloft.net>
Date:	Wed, 23 Dec 2009 13:48:37 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jason.wessel@...driver.com
Cc:	linux-kernel@...r.kernel.org, kgdb-bugreport@...ts.sourceforge.net,
	kdb@....sgi.com, mingo@...e.hu
Subject: Re: [PATCH 07/37] kgdb,sparc: Add in kgdb_arch_set_pc for sparc

From: Jason Wessel <jason.wessel@...driver.com>
Date: Wed, 23 Dec 2009 15:19:20 -0600

> +void kgdb_arch_set_pc(struct pt_regs *regs, unsigned long ip)
> +{
> +       regs->pc = regs->npc;
> +       regs->npc = ip;
> +}
> +

Is this right?

It should probably be something like:

> +       regs->pc = ip;
> +       regs->npc = regs->pc + 4;

and similary for sparc64.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/