linux-kernel - Re: [PATCH 15/37] sparc,sunzilog: Add console polling support for sunzilog serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091223.135028.112586698.davem@davemloft.net>
Date:	Wed, 23 Dec 2009 13:50:28 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	jason.wessel@...driver.com
Cc:	linux-kernel@...r.kernel.org, kgdb-bugreport@...ts.sourceforge.net,
	kdb@....sgi.com, mingo@...e.hu
Subject: Re: [PATCH 15/37] sparc,sunzilog: Add console polling support for
 sunzilog serial driver

From: Jason Wessel <jason.wessel@...driver.com>
Date: Wed, 23 Dec 2009 15:19:28 -0600

> +static void sunzilog_put_poll_char(struct uart_port *port,
> +			unsigned char ch)
> +{
> +	struct uart_sunzilog_port *up = (struct uart_sunzilog_port *)port;
> +
> +	sunzilog_putchar(&up->port, ch);
> +	udelay(2);
> +
> +}
> +#endif /* CONFIG_CONSOLE_POLL */

Just curious, what is the udelay() for?

>  static struct uart_ops sunzilog_pops = {
>  	.tx_empty	=	sunzilog_tx_empty,
>  	.set_mctrl	=	sunzilog_set_mctrl,
> @@ -1013,6 +1061,10 @@ static struct uart_ops sunzilog_pops = {
>  	.request_port	=	sunzilog_request_port,
>  	.config_port	=	sunzilog_config_port,
>  	.verify_port	=	sunzilog_verify_port,
> +#ifdef CONFIG_CONSOLE_POLL
> +	.poll_get_char	= sunzilog_get_poll_char,
> +	.poll_put_char	= sunzilog_put_poll_char,
> +#endif
>  };

Please make the indentation consistent with the rest of those in
this structure.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/