linux-kernel - Re: [patch 1/7] [patch] DT3155: Use pci_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091223233728.GA19703@suse.de>
Date:	Wed, 23 Dec 2009 15:37:29 -0800
From:	Greg KH <gregkh@...e.de>
To:	Simon Horman <horms@...ge.net.au>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 1/7] [patch] DT3155: Use pci_get_device

On Thu, Dec 24, 2009 at 09:02:29AM +1100, Simon Horman wrote:
> On Wed, Dec 23, 2009 at 08:19:32AM -0800, Greg KH wrote:
> > On Wed, Dec 23, 2009 at 07:54:49PM +1100, Simon Horman wrote:
> > > The use of pci_find_device() is deprecated.
> > > 
> > > Signed-off-by: Simon Horman <horms@...ge.net.au>
> > > 
> > > --- 
> > > 
> > > Compile tested only.
> > > 
> > > Alternatively, if pci_find_device() really needs to be used
> > > then this code needs to depend on PCI_LEGACY.
> > > 
> > > Index: gregkh-2.6/drivers/staging/dt3155/dt3155_drv.c
> > > ===================================================================
> > > --- gregkh-2.6.orig/drivers/staging/dt3155/dt3155_drv.c	2009-12-23 18:41:46.000000000 +1100
> > > +++ gregkh-2.6/drivers/staging/dt3155/dt3155_drv.c	2009-12-23 18:42:29.000000000 +1100
> > > @@ -963,7 +963,7 @@ static int find_PCI (void)
> > >    unsigned long base;
> > >    unsigned char irq;
> > >  
> > > -  while ((pci_dev = pci_find_device
> > > +  while ((pci_dev = pci_get_device
> > 
> > You can't just replace these two functions, they operate differently
> > with regard to the reference counting logic.  Otherwise it wouldn't make
> > sense to have 2 different functions :)
> > 
> > So I can't apply this.
> 
> Sorry about that.

No problem, care to fix it up properly?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/