lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Dec 2009 02:53:02 -0500 From: Christoph Hellwig <hch@...radead.org> To: Eric Blake <ebb9@....net> Cc: Dave Chinner <david@...morbit.com>, OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, xfs@....sgi.com, Christoph Hellwig <hch@....de> Subject: Re: utimensat fails to update ctime On Tue, Dec 22, 2009 at 05:42:49AM -0700, Eric Blake wrote: > According to Dave Chinner on 12/22/2009 5:34 AM: > > Yeah, it looks like the change to utimesat() back in 2.6.26 for > > posix conformance made ATTR_CTIME appear outside inode truncation > > and XFS wasn't updated for this change in behaviour at the VFS level. > > Looks simple to fix, but I'm worried about introducing other > > unintended ctime modifications - is there a test suite that checks > > posix compliant atime/mtime/ctime behaviour around anywhere? > > Yes - the gnulib unit test, consisting of: > > http://git.savannah.gnu.org/cgit/gnulib.git/tree/tests/nap.h > http://git.savannah.gnu.org/cgit/gnulib.git/tree/tests/test-utimens-common.h > http://git.savannah.gnu.org/cgit/gnulib.git/tree/tests/test-utimens.h > http://git.savannah.gnu.org/cgit/gnulib.git/tree/tests/test-lutimens.h > http://git.savannah.gnu.org/cgit/gnulib.git/tree/tests/test-futimens.h > http://git.savannah.gnu.org/cgit/gnulib.git/tree/tests/test-futimens.c > http://git.savannah.gnu.org/cgit/gnulib.git/tree/tests/test-utimensat.c > > Taken together, these files produce the executables test-futimens and > test-utimensat which can demonstrate compliance with POSIX. They are also > bundled as part of GNU coreutils (the version bundled with coreutils 8.2 > didn't test for ctime compliance, and coreutils 8.3 hasn't been released > yet) if you use 'make -C gnulib-tests check'. Ok, I'll see if I can add the last GPLv2 licensed version into xfstests. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists