linux-kernel - Re: [ibm-acpi-devel] [Patch] thinkpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091225134157.GC5891@khazad-dum.debian.net>
Date:	Fri, 25 Dec 2009 11:41:57 -0200
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Len Brown <len.brown@...el.com>, Amerigo Wang <amwang@...hat.com>,
	Corentin Chary <corentincj@...aif.net>,
	Marcel Holtmann <marcel@...tmann.org>,
	linux-kernel@...r.kernel.org, ibm-acpi-devel@...ts.sourceforge.net,
	Randy Dunlap <rdunlap@...otime.net>,
	Alan Jenkins <alan-jenkins@...fmail.co.uk>,
	helight.xu@...il.com, Xiaotian Feng <xtfeng@...il.com>,
	akpm@...ux-foundation.org
Subject: Re: [ibm-acpi-devel] [Patch] thinkpad_acpi: fix a build error

On Fri, 25 Dec 2009, Takashi Iwai wrote:
> > "depends on SND || SND = n" takes care of the technical restrictions.
> 
> Yep, that's what I mentioned as Kconfig dependency :)

I think I will do it a bit different, so that you can opt-out ALSA support
and still have thinkpad-acpi built in, with modular ALSA in that case.

Which means that, due to the lack of "depends-but-not-hide", the
"thinkpad-acpi alsa support" kconfig entry will still just disappear due to
a "depends on SND && SND = THINKPAD_ACPI".

I really want a depends that leaves the entry still visible, but greyed out
:-(

> > The warning will be there.  Although I don't warn of missing rfkill
> > functionality if the kernel is missing the rfkill subsystem...
> 
> The messages could be KERN_INFO instead of KERN_WARNING, I think.

It is at KERN_NOTICE right now.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/