linux-kernel - Re: [Patch] console: limit the range of VGACON_SOFT_SCROLLBACK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d75f4610912250559k26463e8fi1c38e54f31ba5120@mail.gmail.com>
Date:	Fri, 25 Dec 2009 20:59:08 +0700
From:	BuraphaLinux Server <buraphalinuxserver@...il.com>
To:	Amerigo Wang <amwang@...hat.com>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [Patch] console: limit the range of VGACON_SOFT_SCROLLBACK_SIZE

On 12/25/09, Amerigo Wang <amwang@...hat.com> wrote:
>
> BuraphaLinux reported that we will trigger a mm warning when
> we CONFIG_VGACON_SOFT_SCROLLBACK_SIZE=65536, this is because
> mm cann't allocate so many pages. We should limit the range
> of CONFIG_VGACON_SOFT_SCROLLBACK_SIZE, don't give a user
> any chance to trigger that.
>
> Reported-by: John Gatewood Ham <buraphalinuxserver@...il.com>
> Signed-off-by: WANG Cong <amwang@...hat.com>
> Cc: David S. Miller <davem@...emloft.net>
>
> ---
> diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig
> index fc7d9bb..8e8f18d 100644
> --- a/drivers/video/console/Kconfig
> +++ b/drivers/video/console/Kconfig
> @@ -37,6 +37,7 @@ config VGACON_SOFT_SCROLLBACK
>  config VGACON_SOFT_SCROLLBACK_SIZE
>         int "Scrollback Buffer Size (in KB)"
>         depends on VGACON_SOFT_SCROLLBACK
> +       range 1 1024
>         default "64"
>         help
>           Enter the amount of System RAM to allocate for the scrollback
>

This fixed the problem.  Thank you for the fix.  I texted on 2.6.32.2
with your patch added, x86_64 kernel.

Tested-by: John Gatewood Ham <buraphalinuxserver@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/