lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 26 Dec 2009 16:12:13 -0500 From: Mike Frysinger <vapier.adi@...il.com> To: Jason Wessel <jason.wessel@...driver.com> Cc: linux-kernel@...r.kernel.org, kgdb-bugreport@...ts.sourceforge.net, kdb@....sgi.com, mingo@...e.hu, Sonic Zhang <Sonic.Zhang@...log.com> Subject: Re: [PATCH 09/37] kgdb,blackfin: Add in kgdb_arch_set_pc for blackfin On Wed, Dec 23, 2009 at 16:19, Jason Wessel wrote: > The new debug core api requires all architectures that use to debug > core to implement a function to set the program counter. > > CC: Mike Frysinger <vapier@...too.org> > Signed-off-by: Jason Wessel <jason.wessel@...driver.com> > --- > arch/blackfin/kernel/kgdb.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/arch/blackfin/kernel/kgdb.c b/arch/blackfin/kernel/kgdb.c > index f1036b6..5965188 100644 > --- a/arch/blackfin/kernel/kgdb.c > +++ b/arch/blackfin/kernel/kgdb.c > @@ -644,6 +644,11 @@ int kgdb_arch_remove_breakpoint(unsigned long addr, char *bundle) > return bfin_probe_kernel_write((char *)addr, bundle, BREAK_INSTR_SIZE); > } > > +void kgdb_arch_set_pc(struct pt_regs *regs, unsigned long ip) > +{ > + regs->retx = ip; > +} > + > int kgdb_arch_init(void) > { > kgdb_single_step = 0; Sonic should be able to check this. our pc handling seems a little wonky atm: arch/blackfin/kernel/kgdb.c: void pt_regs_to_gdb_regs(unsigned long *gdb_regs, struct pt_regs *regs) { ... gdb_regs[BFIN_RETI] = regs->pc; gdb_regs[BFIN_RETX] = regs->retx; gdb_regs[BFIN_PC] = regs->pc; ... } ... void gdb_regs_to_pt_regs(unsigned long *gdb_regs, struct pt_regs *regs) { ... regs->pc = gdb_regs[BFIN_PC]; regs->retx = gdb_regs[BFIN_PC]; /* nothing for BFIN_RETI */ ... } -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists