linux-kernel - Re: [PATCH 10/37] kgdb: Make mem access function weak in kgdb.c and kgdb.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd0f97a0912261307t44d27b4eyf238b3a794e6862@mail.gmail.com>
Date:	Sat, 26 Dec 2009 16:07:10 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	Jason Wessel <jason.wessel@...driver.com>
Cc:	linux-kernel@...r.kernel.org, kgdb-bugreport@...ts.sourceforge.net,
	kdb@....sgi.com, mingo@...e.hu, Sonic Zhang <sonic.adi@...il.com>
Subject: Re: [PATCH 10/37] kgdb: Make mem access function weak in kgdb.c and 
	kgdb.h

On Wed, Dec 23, 2009 at 16:19, Jason Wessel wrote:
> L1 instruction memory and MMR memory on blackfin can not be accessed by
> common functions probe_kernel_read() and probe_kernel_write().
> Blackfin asks for 2/4 byte align access to MMR memory and DMA access to
> L1 instruction memory. These functions need to be reimplemented in
> architecture specific kgdb.c. Update documentation and prototypes as
> well.

considering these functions were made weak only because of
probe_kernel_(read|write), then perhaps it makes more sense to move
the work there.  it would mean that all consumers of these functions
work properly instead of just kgdb.

probe_kernel_write is already weak ... we just need to add weak to
probe_kernel_read i think, and make the functions available via a
"default" symbol so that arch overrides can tail back into the common
code when it makes sense.
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/