linux-kernel - Re: [patch] Makefile: Unexport LANG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B359166.3050106@redhat.com>
Date:	Fri, 25 Dec 2009 23:30:30 -0500
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Simon Horman <horms@...ge.net.au>
CC:	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	"H. Peter Anvin" <hpa@...or.com>, Michal Marek <mmarek@...s.cz>,
	Roland Dreier <rdreier@...co.com>,
	Sam Ravnborg <sam@...nborg.org>
Subject: Re: [patch] Makefile: Unexport LANG

Simon Horman wrote:
> The recent changes to setting and unexport various LC_ variables
> produces a problem on my system (Debian sid).
> 
> $ locale
> LANG=ja_JP.utf8
> LANGUAGE=ja_JP.utf8
> LC_CTYPE="ja_JP.utf8"
> LC_NUMERIC="ja_JP.utf8"
> LC_TIME="ja_JP.utf8"
> LC_COLLATE="ja_JP.utf8"
> LC_MONETARY="ja_JP.utf8"
> LC_MESSAGES="ja_JP.utf8"
> LC_PAPER="ja_JP.utf8"
> LC_NAME="ja_JP.utf8"
> LC_ADDRESS="ja_JP.utf8"
> LC_TELEPHONE="ja_JP.utf8"
> LC_MEASUREMENT="ja_JP.utf8"
> LC_IDENTIFICATION="ja_JP.utf8"
> LC_ALL=ja_JP.utf8
> 
> Without this patch:
> $ make
> make[2]: ??: ?? make ? -jN ?????????: jobserver ??????????.
> make[2]: ??: ?? make ? -jN ?????????: jobserver ??????????.
> 
> With this patch:
> $ make
> ...
> make[2]: warning: -jN forced in submake: disabling jobserver mode.
> make[2]: warning: -jN forced in submake: disabling jobserver mode.
> ...
> 
> Cc: H. Peter Anvin <hpa@...or.com>
> Cc: Michal Marek <mmarek@...s.cz>
> Cc: Roland Dreier <rdreier@...co.com>
> Cc: Sam Ravnborg <sam@...nborg.org>
> Cc: Masami Hiramatsu <mhiramat@...hat.com>
> Signed-off-by: Simon Horman <horms@...ge.net.au>

Tested on Fedora 11 too, and it works good. Thank you!

Tested-by: Masami Hiramatsu <mhiramat@...hat.com>

> 
> Index: linux-2.6/Makefile
> ===================================================================
> --- linux-2.6.orig/Makefile	2009-12-24 22:09:29.000000000 +1100
> +++ linux-2.6/Makefile	2009-12-24 22:10:58.000000000 +1100
> @@ -17,6 +17,7 @@ NAME = Man-Eating Seals of Antiquity
>  MAKEFLAGS += -rR --no-print-directory
>  
>  # Avoid funny character set dependencies
> +unexport LANG
>  unexport LC_ALL
>  LC_CTYPE=C
>  LC_COLLATE=C
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/