linux-kernel - Re: [PATCH] thinkpad_acpi.c: Remove #define TPACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1261802563.2568.75.camel@Joe-Laptop.home>
Date:	Fri, 25 Dec 2009 20:42:43 -0800
From:	Joe Perches <joe@...ches.com>
To:	Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
	Len Brown <len.brown@...el.com>,
	ibm-acpi-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thinkpad_acpi.c: Remove #define TPACPI_<level>s for
 printks

On Sat, 2009-12-26 at 02:20 -0200, Henrique de Moraes Holschuh wrote:
> Why would I want a parameter macro instead of a straightforward bunch of
> #defines ?

To make grep a bit easier.

> It is not like the #defines are harder to understand than this
> pr_fmt thing.

Nope, not particularly difficult, but less standard.

> I don't want the pr_foo() siliness in code I maintain.

Your choice.

cheers,

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/