linux-kernel - Re: [PATCH] parisc: test off by one in sgl_frem() and dbl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4B37CD6A.2000506@gmail.com>
Date:	Sun, 27 Dec 2009 22:11:06 +0100
From:	Roel Kluin <roel.kluin@...il.com>
To:	James Bottomley <James.Bottomley@...senPartnership.com>
CC:	Kyle McMartin <kyle@...artin.ca>, Helge Deller <deller@....de>,
	"James E.J. Bottomley" <jejb@...isc-linux.org>,
	John David Anglin <dave@...uly1.hia.nrc.ca>,
	linux-parisc@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] parisc: test off by one in sgl_frem() and dbl_frem()

Op 27-12-09 16:30, James Bottomley schreef:
> On Sun, 2009-12-27 at 14:21 +0100, Roel Kluin wrote:
>> With `while (stepcount-- > 0)' stepcount reaches -1 after the loop.
> 
> This is true, but seems to be by design

>> -	if (stepcount > 0 || Sgl_iszero(opnd1)) {
>> +	if (stepcount >= 0 || Sgl_iszero(opnd1)) {

> 
> Your patch does nothing to the actual execution flow (Sgl_iszero is true
> if stepcount == 0) ... what's the point of applying it?
> 
> James

Ok, please ignore and thanks (also to Dave) for review.

Roel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/