linux-kernel - Re: [tip:sched/urgent] sched: might_sleep(): Make file parameter const char *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100104104904.65f57a24@marrow.netinsight.se>
Date:	Mon, 4 Jan 2010 10:49:04 +0100
From:	Simon Kagstrom <simon.kagstrom@...insight.net>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, mingo@...e.hu,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/urgent] sched: might_sleep(): Make file parameter
 const char *

(Back from vacation, hence the delayed response)

On Tue, 29 Dec 2009 13:11:48 +0100
Peter Zijlstra <peterz@...radead.org> wrote:

> On Mon, 2009-12-28 at 10:10 +0000, tip-bot for Simon Kagstrom wrote:
> 
> > Fixes a warning when building with g++:
> 
> However did you manage to build stuff with g++? The kernel very
> frequently uses C++ keywords for other things.

I expected this question :-)

Yes, there are some workarounds we have to make to get it compiling
(like #define new NEW prior to including the headers), but it works
out. I know this is something you shouldn't do, and I debated whether
to mention C++ at all. 


Anyway, I think the change itself makes sense for plain C as well. The
comment just described the context where it showed up for us.

// Simon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/