linux-kernel - Re: [tip:sched/urgent] sched: might_sleep(): Make file parameter const char *

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 04 Jan 2010 11:36:25 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Simon Kagstrom <simon.kagstrom@...insight.net>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, mingo@...e.hu,
	linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/urgent] sched: might_sleep(): Make file parameter
 const char *

On Mon, 2010-01-04 at 10:49 +0100, Simon Kagstrom wrote:
> (Back from vacation, hence the delayed response)
> 
> On Tue, 29 Dec 2009 13:11:48 +0100
> Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > On Mon, 2009-12-28 at 10:10 +0000, tip-bot for Simon Kagstrom wrote:
> > 
> > > Fixes a warning when building with g++:
> > 
> > However did you manage to build stuff with g++? The kernel very
> > frequently uses C++ keywords for other things.
> 
> I expected this question :-)
> 
> Yes, there are some workarounds we have to make to get it compiling
> (like #define new NEW prior to including the headers), but it works
> out. I know this is something you shouldn't do, and I debated whether
> to mention C++ at all. 
> 
> 
> Anyway, I think the change itself makes sense for plain C as well. The
> comment just described the context where it showed up for us.

Oh sure, the change is fine, just wondering what specific drug you were
using as it was not the regular kernel kind ;-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/