linux-kernel - Re: iscsi warning in 2.6.33-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B44E790.9070800@cs.wisc.edu>
Date:	Wed, 06 Jan 2010 13:42:08 -0600
From:	Mike Christie <michaelc@...wisc.edu>
To:	open-iscsi@...glegroups.com
CC:	Tao Ma <tao.ma@...cle.com>, linux-kernel@...r.kernel.org
Subject: Re: iscsi warning in 2.6.33-rc2

On 12/29/2009 11:43 PM, Tao Ma wrote:
> Hi all,
> 	I met with this warning when using iscsi with the 2.6.33-rc2.
>
> ------------[ cut here ]------------
> WARNING: at drivers/scsi/libiscsi_tcp.c:996

....

>
> The other thing I can confirm is that I didn't meet with such problem in
> 2.6.32-rc8.
>

Sorry for the late reply. I am just getting back.

I think this is due to the kfifo changes that got merged recently.

For the iscsi side if there is nothing in the r2tqueue fifo at this time 
it is fine. It just means that there is nothing to process, so I think 
that the warn on should just not have been added.

Could you try the attached patch? I have only compile tested it. I am 
starting up some testing for the patch and the other fifo changes that 
got merged now.

View attachment "iscsi-do-not-warn-on-empty-r2t.patch" of type "text/x-patch" (791 bytes)