linux-kernel - Re: [Kgdb-bugreport] [PATCH 09/37] kgdb,blackfin: Add in kgdb_arch_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B44E7E3.10305@windriver.com>
Date:	Wed, 06 Jan 2010 13:43:31 -0600
From:	Jason Wessel <jason.wessel@...driver.com>
To:	Sonic Zhang <sonic.adi@...il.com>
CC:	"Zhang, Sonic" <Sonic.Zhang@...log.com>,
	Mike Frysinger <vapier.adi@...il.com>,
	kgdb-bugreport@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	mingo@...e.hu
Subject: Re: [Kgdb-bugreport] [PATCH 09/37] kgdb,blackfin: Add in kgdb_arch_set_pc
 for blackfin

Sonic Zhang wrote:
> I have to recall my last wrong patch.
>
> In blackfin, kgdb is running in delayed exception IRQ5 other than in
> exception IRQ3 directly.  Register reti other than retx in pt_regs is
> the kgdb return address. So, don't put PC in gdb_regs into retx.
>
> Sonic Zhang
>
> Index: arch/blackfin/kernel/kgdb.c
> ============================
> --- arch/blackfin/kernel/kgdb.c	(revision 8105)
> +++ arch/blackfin/kernel/kgdb.c	(revision 8106)
> @@ -147,7 +147,7 @@
>  	regs->lb1 = gdb_regs[BFIN_LB1];
>  	regs->usp = gdb_regs[BFIN_USP];
>  	regs->syscfg = gdb_regs[BFIN_SYSCFG];
> -	regs->retx = gdb_regs[BFIN_PC];
> +	regs->retx = gdb_regs[BFIN_RETX];
>  	regs->retn = gdb_regs[BFIN_RETN];
>  	regs->rete = gdb_regs[BFIN_RETE];
>  	regs->pc = gdb_regs[BFIN_PC];
>
>   

Sonic,

I pulled in this patch, and made the changes the Mike talked about with
respect to cleaning up the arch specific kgdb.c for blackfin.  See the
attached patch.

Your patch and the one here will go into kgdb-next and onto linux-next.

At some point you sent a patch for cpu switching that was blackfin
specific.  There is new generic code in the debug core for doing this
without exiting the debug context.  At some point you should test this
and figure out if something further needs to be done that is blackfin
specific.

Thanks,
Jason.

View attachment "blackfin_kgdb_cleanup.patch" of type "text/x-diff" (9442 bytes)