linux-kernel - Re: [PATCH 4/4] uml: line.c: avoid NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100107043241.GA19313@c2.user-mode-linux.org>
Date:	Wed, 6 Jan 2010 23:32:41 -0500
From:	Jeff Dike <jdike@...toit.com>
To:	Alexander Beregalov <a.beregalov@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] uml: line.c: avoid NULL pointer dereference

On Thu, Jan 07, 2010 at 04:48:41AM +0300, Alexander Beregalov wrote:
> Assign tty only if line is not NULL.

>  	if (line)
> +		tty = line->tty;
>  		chan_interrupt(&line->chan_list, &line->task, tty, irq);
>  	return IRQ_HANDLED;

Even if the thinking is correct, aren't you missing some braces?

				Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/