linux-kernel - Re: [PATCH 4/4] uml: line.c: avoid NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a4423d671001070756u2c6eb8f3p12bf3681b96ba342@mail.gmail.com>
Date:	Thu, 7 Jan 2010 18:56:51 +0300
From:	Alexander Beregalov <a.beregalov@...il.com>
To:	Jeff Dike <jdike@...toit.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] uml: line.c: avoid NULL pointer dereference

2010/1/7 Jeff Dike <jdike@...toit.com>:
> On Thu, Jan 07, 2010 at 04:48:41AM +0300, Alexander Beregalov wrote:
>> Assign tty only if line is not NULL.
>
>>       if (line)
>> +             tty = line->tty;
>>               chan_interrupt(&line->chan_list, &line->task, tty, irq);
>>       return IRQ_HANDLED;
>
> Even if the thinking is correct, aren't you missing some braces?

Oops, sorry, I will send another version.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/