linux-kernel - Re: latest git pull changed drivers/scsi/lpfc/lpfc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1262875521.3025.5.camel@mulgrave.site>
Date:	Thu, 07 Jan 2010 09:45:21 -0500
From:	James Bottomley <James.Bottomley@...e.de>
To:	Thomas Backlund <tmb@...driva.org>
Cc:	linux-kernel@...r.kernel.org, james.smart@...lex.com,
	torvalds@...ux-foundation.org
Subject: Re: latest git pull changed drivers/scsi/lpfc/lpfc_hw4.h to
 executable

On Thu, 2010-01-07 at 12:16 +0200, Thomas Backlund wrote:
> At latest pull, lpfs_hw4.h got set to executable...
> 
> git show def9c7a994f194377a23e687e6fd39b46c3ce631 --summary
> 
> states:
> 
> commit def9c7a994f194377a23e687e6fd39b46c3ce631
> Author: James Smart <james.smart@...lex.com>
> Date:   Mon Dec 21 17:02:28 2009 -0500
> 
>      [SCSI] lpfc 8.3.7: Fix hardware/SLI relates issues
> 
>      Fix hardware/SLI relates issues:
>      - Fix CNA uses more than one EQ when in INTx interrupt mode.
>      - Fix driver tries to process failed read FCF record mailbox request.
>      - Fix allocating single receive buffer breaks FCoE receive queue.
>      - Support new read FCF record mailbox error case.
> 
>      Signed-off-by: James Smart <james.smart@...lex.com>
>      Signed-off-by: James Bottomley <James.Bottomley@...e.de>
> 
>   mode change 100644 => 100755 drivers/scsi/lpfc/lpfc_hw4.h
> 
> 
> While looking at the same tree, I also noticed that:
> drivers/scsi/lpfc/lpfc_hbadisc.c is also executable.
> 
> I guess they should be fixed.

I'll remove the x flag for both.  I suppose a commit check that warns on
executables might be in order, since adding them to the tree is a rare
exception rather than a usual occurrence.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/