linux-kernel - Re: MSI broken in libata?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B4A815A.60503@gmail.com>
Date:	Sun, 10 Jan 2010 19:39:38 -0600
From:	Robert Hancock <hancockrwd@...il.com>
To:	Tejun Heo <tj@...nel.org>
CC:	Torsten Kaiser <just.for.lkml@...glemail.com>,
	linux-kernel@...r.kernel.org, Jeff Garzik <jgarzik@...ox.com>,
	linux-ide@...r.kernel.org
Subject: Re: MSI broken in libata?

On 01/10/2010 07:15 PM, Tejun Heo wrote:
> On 01/10/2010 01:33 PM, Torsten Kaiser wrote:
>> I did try the patch from Robert Hancock in
>> http://lkml.org/lkml/2010/1/6/417 ,but without success.
>>
>> if you need any more information, or have something for me to try,
>> please just ask. I did look at the code and the documentation about
>> enabling MSI, but did not see anything (obvious) wrong, so I don't
>> know what to try next.
>
> Can you please try the attached patch?
>
> Thanks.
>

It'd be interesting to see if it makes a difference, but I don't think 
the patch is quite right. According to the datasheet, doing the MSI ack 
while the interrupt source is still pending will cause a new MSI to be 
sent, so if you do it before handling the interrupt you'll generate a 
spurious interrupt after every real one.

Though, apparently my patch that did the MSI ack after the handling 
didn't help, so either that's wrong or the problem is unrelated. (I tend 
to suspect the latter, given that sata_nv is also failing in the same way.)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/