linux-kernel - Re: MSI broken in libata?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B4A8A54.8030406@kernel.org>
Date:	Mon, 11 Jan 2010 11:17:56 +0900
From:	Tejun Heo <tj@...nel.org>
To:	Robert Hancock <hancockrwd@...il.com>
CC:	Torsten Kaiser <just.for.lkml@...glemail.com>,
	linux-kernel@...r.kernel.org, Jeff Garzik <jgarzik@...ox.com>,
	linux-ide@...r.kernel.org
Subject: Re: MSI broken in libata?

Hello, Robert.

On 01/11/2010 10:39 AM, Robert Hancock wrote:
> It'd be interesting to see if it makes a difference, but I don't think
> the patch is quite right. According to the datasheet, doing the MSI ack
> while the interrupt source is still pending will cause a new MSI to be
> sent, so if you do it before handling the interrupt you'll generate a
> spurious interrupt after every real one.

Ah... okay, so the generation of MSI is level triggered?  If so, your
original patch is correct.  I was thinking it might be edge triggered
and it should be cleared before checking master event mask.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/