linux-kernel - Re: [PATCH] m68knommu: change definitions of __pa() and _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1001111652500.17145@localhost.localdomain>
Date:	Mon, 11 Jan 2010 16:53:56 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Greg Ungerer <gerg@...pgear.com>
cc:	gerg@...inux.org, linux-m68k@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68knommu: change definitions of __pa() and __va()



On Tue, 12 Jan 2010, Greg Ungerer wrote:
> +#else
> +#define page_to_phys(page)	((page - mem_map) << PAGE_SHIFT)
> +#define page_to_bus(page)	((page - mem_map) << PAGE_SHIFT)
> +#endif

Ok, so the old ones were total crap too, but when moving things around, 
don't just copy the crap like this.

Look at those two #define's for five seconds, and ask yourself what is 
wrong with them. Those macros are not good.

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/