linux-kernel - Re: [PATCH]drivers/ata/libata-eh.c:1509 unneeded memset()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5543f88f1001111655t7ae4a4eamd4f010b5ab7e7c82@mail.gmail.com>
Date:	Mon, 11 Jan 2010 16:55:45 -0800
From:	Marc Bejarano <beej@...j.org>
To:	René Bolldorf <xsecute@...glemail.com>
Cc:	linux-scsi@...r.kernel.org, linux-ide@...r.kernel.org,
	James Bottomley <James.Bottomley@...e.de>,
	linux-kernel@...r.kernel.org, jgarzik@...ox.com
Subject: Re: [PATCH]drivers/ata/libata-eh.c:1509 unneeded memset()

2010/1/11 René Bolldorf <xsecute@...glemail.com>:
> I hope that's good enough explained :-).

definitely an improvement, but i think jeff is going to want your
S-O-B and at least a patch title, if no description :)


> +       /* make sure sense_buf is cleared then atapi_eh_request_sense is
> called.

s/then/when/ ?

> +        * (to make sure nothing get's reused.)

probably not necessary

> +        * thanks to James Bottomley

this may be better in a patch description

cheers,
marc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/