linux-kernel - Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o KMS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878wc3j6mm.fsf@pollan.anholt.net>
Date:	Tue, 12 Jan 2010 14:33:21 -0800
From:	Eric Anholt <eric@...olt.net>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Zhenyu Wang <zhenyuw@...ux.intel.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	pm list <linux-pm@...ts.linux-foundation.org>,
	dri-devel@...ts.sourceforge.net
Subject: Re: [PATCH] DRM / i915: Fix resume regression on MSI Wind U100 w/o
 KMS

On Sat, 9 Jan 2010 00:45:33 +0100, "Rafael J. Wysocki" <rjw@...k.pl> wrote:
> From: Rafael J. Wysocki <rjw@...k.pl>
> 
> Commit cbda12d77ea590082edb6d30bd342a67ebc459e0 (drm/i915: implement
> new pm ops for i915), among other things, removed the .suspend and
> .resume pointers from the struct drm_driver object in i915_drv.c,
> which broke resume without KMS on my MSI Wind U100.
> 
> Fix this by reverting that part of commit cbda12d77ea59.
> 
> Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>

Applied, with a little comment for the next poor person having to figure
out the difference between these two suspend/resume paths.

(And yes, I'd love to see the stealth mode die sometime soonish.  It's
not like attaching intelfb didn't make the user-mode 2D driver fail
frequently, so it's not a great "feature" for us to be maintaining
support for.  From what I understand most distros blacklisted the
intelfb driver anyway.)

Content of type "application/pgp-signature" skipped