linux-kernel - Re: Crypto test results unused?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100112224404.GA5480@gondor.apana.org.au>
Date:	Wed, 13 Jan 2010 09:44:05 +1100
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Krzysztof Halasa <khc@...waw.pl>
Cc:	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: Crypto test results unused?

On Tue, Jan 12, 2010 at 06:55:07PM +0100, Krzysztof Halasa wrote:
>
> Currently the /proc/crypto contains:
> 
> - for passed tests: "selftest: passed" (which is of course right)
> 
> - for failed tests: "selftest: unknown" (which is a surprise for me):
> 
> alg: skcipher: Test 1 failed on encryption for ecb(des)-ixp4xx
> 00000000: 01 23 45 67 89 ab cd e7
> 
> name         : ecb(des)
> driver       : ecb(des)-ixp4xx
> module       : ixp4xx_crypto
> priority     : 300
> refcnt       : 1
> selftest     : unknown
> type         : ablkcipher
> async        : yes
> blocksize    : 8
> min keysize  : 8
> max keysize  : 8
> ivsize       : 0
> geniv        : <default>

This is fine.

> - for routines without a test: "selftest: passed" (which isn't true
>   either)
> 
> alg: No test for authenc(hmac(md5),cbc(des)) (authenc(hmac(md5),cbc(des))-ixp4xx)

This should be fixed by adding some code to test authenc algorithms
by combining the test vectors of its components.
 
> I think we need a way to differentiate between "really unknown" and
> "failed", do we need another flag for it?

It doesn't matter.  We test all algorithms at registration time.
So unknown means failed except during registration.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/