linux-kernel - Re: [PATCH] Fix reset of ramzswap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d760cf2d1001112130p8489b93uccd6a4650ff4a4a8@mail.gmail.com>
Date:	Tue, 12 Jan 2010 11:00:18 +0530
From:	Nitin Gupta <ngupta@...are.org>
To:	"minchan.kim" <minchan.kim@...il.com>
Cc:	Greg KH <greg@...ah.com>, LKML <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>
Subject: Re: [PATCH] Fix reset of ramzswap

On Tue, Jan 12, 2010 at 10:06 AM, minchan.kim <minchan.kim@...il.com> wrote:
> ioctl(cmd=reset)
>        -> bd_holder check (if whoever hold bdev, return -EBUSY)
>        -> ramzswap_ioctl_reset_device
>                -> reset_device
>                        -> bd_release
>
> bd_release is called by reset_device.
> but ramzswap_ioctl always checks bd_holder before
> reset_device. it means reset ioctl always fails.

Are you sure you checked this patch?

This check makes sure that you cannot reset an active swap device.
When device in swapoff'ed the ioctl works as expected.

Greg: Can you please exclude earlier 'Free memory when create_device
is failed' patch?
That patch is correct however, my pending patch series conflicts with
that. So, I will
instead include that fix with this patch series (and add appropriate
signed-off-by)

Thanks,
Nitin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/