linux-kernel - Re: [PATCH] Fix reset of ramzswap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1263275308.23507.18.camel@barrios-desktop>
Date:	Tue, 12 Jan 2010 14:48:28 +0900
From:	Minchan Kim <minchan.kim@...il.com>
To:	Nitin Gupta <ngupta@...are.org>
Cc:	Greg KH <greg@...ah.com>, LKML <linux-kernel@...r.kernel.org>,
	linux-mm <linux-mm@...ck.org>
Subject: Re: [PATCH] Fix reset of ramzswap

On Tue, 2010-01-12 at 11:00 +0530, Nitin Gupta wrote:
> On Tue, Jan 12, 2010 at 10:06 AM, minchan.kim <minchan.kim@...il.com> wrote:
> > ioctl(cmd=reset)
> >        -> bd_holder check (if whoever hold bdev, return -EBUSY)
> >        -> ramzswap_ioctl_reset_device
> >                -> reset_device
> >                        -> bd_release
> >
> > bd_release is called by reset_device.
> > but ramzswap_ioctl always checks bd_holder before
> > reset_device. it means reset ioctl always fails.
> 
> Are you sure you checked this patch?

> This check makes sure that you cannot reset an active swap device.
> When device in swapoff'ed the ioctl works as expected.
> 
It seems my test was wrong. 
Maybe my test case don't swapoff swap device. 
Sorry. Ignore this patch, pz.
Thanks for the reivew, Nitin. 

I have one more patch. But I don't want to conflict your pending
patches. If it is right, pz, merge this patch with your pending series.

>>From bf810ec09761b0f37eca7ba22d72fb2b1f2cba50 Mon Sep 17 00:00:00 2001
From: Minchan Kim <minchan.kim@...il.com>
Date: Tue, 12 Jan 2010 14:46:46 +0900
Subject: [PATCH] Remove unnecessary check of ramzswap_write

Nitin already implement swap slot free callback.
So, we don't need this test any more.

Signed-off-by: Minchan Kim <minchan.kim@...il.com>
---
 drivers/staging/ramzswap/ramzswap_drv.c |    8 --------
 1 files changed, 0 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/ramzswap/ramzswap_drv.c
b/drivers/staging/ramzswap/ramzswap_drv.c
index 18196f3..575a147 100644
--- a/drivers/staging/ramzswap/ramzswap_drv.c
+++ b/drivers/staging/ramzswap/ramzswap_drv.c
@@ -784,14 +784,6 @@ static int ramzswap_write(struct ramzswap *rzs,
struct bio *bio)
 	src = rzs->compress_buffer;
 
 	/*
-	 * System swaps to same sector again when the stored page
-	 * is no longer referenced by any process. So, its now safe
-	 * to free the memory that was allocated for this page.
-	 */
-	if (rzs->table[index].page)
-		ramzswap_free_page(rzs, index);
-
-	/*
 	 * No memory ia allocated for zero filled pages.
 	 * Simply clear zero page flag.
 	 */
-- 
1.5.6.3




-- 
Kind regards,
Minchan Kim

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/