[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.LNX.2.00.1001132143550.30977@pobox.suse.cz>
Date: Wed, 13 Jan 2010 21:44:49 +0100 (CET)
From: Jiri Kosina <jkosina@...e.cz>
To: Jiri Slaby <jirislaby@...il.com>
Cc: linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-media@...r.kernel.org, Pekka Sarnila <sarnila@...t.fi>
Subject: Re: [PATCH 1/1] HID: ignore afatech 9016
On Wed, 13 Jan 2010, Jiri Slaby wrote:
> >> --- a/drivers/hid/usbhid/hid-quirks.c
> >> +++ b/drivers/hid/usbhid/hid-quirks.c
> >> @@ -41,7 +41,7 @@ static const struct hid_blacklist {
> >> { USB_VENDOR_ID_SAITEK, USB_DEVICE_ID_SAITEK_RUMBLEPAD, HID_QUIRK_BADPAD },
> >> { USB_VENDOR_ID_TOPMAX, USB_DEVICE_ID_TOPMAX_COBRAPAD, HID_QUIRK_BADPAD },
> >>
> >> - { USB_VENDOR_ID_AFATECH, USB_DEVICE_ID_AFATECH_AF9016, HID_QUIRK_FULLSPEED_INTERVAL },
> >> + { USB_VENDOR_ID_AFATECH, USB_DEVICE_ID_AFATECH_AF9016, HID_QUIRK_IGNORE },
> >
> > Hmm, why do we keep HID_QUIRK_IGNORE anyway, when we already have generic
> > hid_ignore_list[]?
>
> You returned it back because of dynamic quirks...
Right you are.
> > We don't set it for any device in the current codebase any more.
>
> Oh yeah, it's hard for people who don't remember code they wrote :).
Oh, right ... happened to me as well, see a few lines above :)
> Will respin. Thanks for the reminder.
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists