[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1263634081-6644-1-git-send-email-jslaby@suse.cz>
Date: Sat, 16 Jan 2010 10:28:01 +0100
From: Jiri Slaby <jslaby@...e.cz>
To: akpm@...ux-foundation.org
Cc: linux-kernel@...r.kernel.org, jirislaby@...il.com,
Tomaz Mertelj <tomaz.mertelj@...st.arnes.si>,
Jean Delvare <khali@...ux-fr.org>
Subject: [PATCH 1/1] HWMON: amc6821, fix lock imbalance
Stanse found a lock imbalance in set_fan1_div. data->update_lock
is unlocked twice on a fail path.
Triggerable by writing value other than 2 and 4 to fan1_div.
Signed-off-by: Jiri Slaby <jslaby@...e.cz>
Cc: Tomaz Mertelj <tomaz.mertelj@...st.arnes.si>
Cc: Jean Delvare <khali@...ux-fr.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>
---
drivers/hwmon/amc6821.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/hwmon/amc6821.c b/drivers/hwmon/amc6821.c
index 1c89d92..fa9708c 100644
--- a/drivers/hwmon/amc6821.c
+++ b/drivers/hwmon/amc6821.c
@@ -686,7 +686,6 @@ static ssize_t set_fan1_div(
data->fan1_div = 4;
break;
default:
- mutex_unlock(&data->update_lock);
count = -EINVAL;
goto EXIT;
}
--
1.6.5.7
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists