linux-kernel - Re: [PATCH 1/1] HWMON: amc6821, fix lock imbalance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 16 Jan 2010 11:02:57 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	jirislaby@...il.com, Tomaz Mertelj <tomaz.mertelj@...st.arnes.si>
Subject: Re: [PATCH 1/1] HWMON: amc6821, fix lock imbalance

On Sat, 16 Jan 2010 10:28:01 +0100, Jiri Slaby wrote:
> Stanse found a lock imbalance in set_fan1_div. data->update_lock
> is unlocked twice on a fail path.
> 
> Triggerable by writing value other than 2 and 4 to fan1_div.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Tomaz Mertelj <tomaz.mertelj@...st.arnes.si>
> Cc: Jean Delvare <khali@...ux-fr.org>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> ---
>  drivers/hwmon/amc6821.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hwmon/amc6821.c b/drivers/hwmon/amc6821.c
> index 1c89d92..fa9708c 100644
> --- a/drivers/hwmon/amc6821.c
> +++ b/drivers/hwmon/amc6821.c
> @@ -686,7 +686,6 @@ static ssize_t set_fan1_div(
>  		data->fan1_div = 4;
>  		break;
>  	default:
> -		mutex_unlock(&data->update_lock);
>  		count = -EINVAL;
>  		goto EXIT;
>  	}

Patch pending in my queue already.
ftp://ftp.kernel.org/pub/linux/kernel/people/jdelvare/linux-2.6/jdelvare-hwmon/hwmon-amc6821-double-unlock-bug.patch

But thanks for reporting anyway.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/