linux-kernel - Re: [PATCH] console/vgacon.c: mark file-local symbol static.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100117011822.GA6272@srcf.ucam.org>
Date:	Sun, 17 Jan 2010 01:18:22 +0000
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Thiago Farina <tfransosi@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Uwe Geuder <ubuntuLp-ugeuder@...akemail.com>,
	Pekka Enberg <penberg@...helsinki.fi>
Subject: Re: [PATCH] console/vgacon.c: mark file-local symbol static.

On Sat, Jan 16, 2010 at 05:52:13PM -0500, Thiago Farina wrote:
> warning: symbol 'vgacon_text_mode_force' was not declared. Should it be static?
> 
> Signed-off-by: Thiago Farina <tfransosi@...il.com>
> ---
>  drivers/video/console/vgacon.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/console/vgacon.c b/drivers/video/console/vgacon.c
> index cc4bbbe..19e474d 100644
> --- a/drivers/video/console/vgacon.c
> +++ b/drivers/video/console/vgacon.c
> @@ -112,7 +112,7 @@ static int 		vga_video_font_height;
>  static int 		vga_scan_lines		__read_mostly;
>  static unsigned int 	vga_rolled_over;
>  
> -int vgacon_text_mode_force = 0;
> +static int vgacon_text_mode_force = 0;

Should probably lose the assignment while we're at it?

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/