lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 20 Jan 2010 22:27:31 +0100 From: Oliver Neukum <oliver@...kum.org> To: "Rick L. Vinyard Jr." <rvinyard@...nmsu.edu> Cc: linux-kernel@...r.kernel.org, felipe.balbi@...ia.com, pavel@....cz, jayakumar.lkml@...il.com, linux-fbdev@...r.kernel.org, krzysztof.h1@...pl, akpm@...ux-foundation.org, linux-usb@...r.kernel.org, linux-input@...r.kernel.org, jkosina@...e.cz, dmitry.torokhov@...il.com Subject: Re: [PATCH] hid: Logitech G13 driver 0.0.4 Am Mittwoch, 20. Januar 2010 21:47:22 schrieb Rick L. Vinyard Jr.: > +static ssize_t g13_name_store(struct device *dev, > + struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + struct g13_data *data = dev_get_drvdata(dev); > + size_t limit = count; > + char *end; > + > + spin_lock(&data->lock); > + > + if (data->name != NULL) { > + kfree(data->name); > + data->name = NULL; > + } > + > + end = strpbrk(buf, "\n\r"); > + if (end != NULL) > + limit = end - buf; > + > + if (end != buf) { > + > + if (limit > 100) > + limit = 100; > + > + data->name = kzalloc(limit+1, GFP_KERNEL); While you hold a spinlock, memory allocations must be done with GFP_ATOMIC. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists